Skip to content

Output of doc data tool #1448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 30, 2019
Merged

Output of doc data tool #1448

merged 2 commits into from
Jul 30, 2019

Conversation

som-snytt
Copy link
Contributor

@som-snytt som-snytt commented Jul 19, 2019

Run under 2.13, but with local paths elided from output.

More work is needed on the tool side to restore useful text and be convenient to run.

Fixes: #1444

Still needs addition of previous material.
- option: "-javabootclasspath"
schema:
type: "Path"
arg: "path"
default: "/usr/lib/jvm/java-8-openjdk-amd64/jre/lib/resources.jar:/usr/lib/jvm/java-8-openjdk-amd64/jre/lib/rt.jar:/usr/lib/jvm/java-8-openjdk-amd64/jre/lib/sunrsasign.jar:/usr/lib/jvm/java-8-openjdk-amd64/jre/lib/jsse.jar:/usr/lib/jvm/java-8-openjdk-amd64/jre/lib/jce.jar:/usr/lib/jvm/java-8-openjdk-amd64/jre/lib/charsets.jar:/usr/lib/jvm/java-8-openjdk-amd64/jre/lib/jfr.jar:/usr/lib/jvm/java-8-openjdk-amd64/jre/classes"
default: ""
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are run-specific, I think that's why I added the note on the main page.

description: "Enable optimizer warnings: `_` for all, `-opt-warnings:help` to list choices."
- option: "-optimise"
description: "Enable optimizer warnings"
- option: "-optimize"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a clear improvement.

schema:
type: "Boolean"
description: "Retains pre 2.10 behavior of less aggressive truncation of least upper bounds."
description: "Former graveyard for language-forking extensions."
Copy link
Contributor Author

@som-snytt som-snytt Jul 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean deprecated options aren't currently distinguished?

This had a special note before. Probably the tool should inject notes, modified default values, etc.

default: "255"
min: "72"
max: "255"
description: "Maximum filename length for generated classes"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this was removed without replacement (fixed at 255). Maybe it would be nice to document that somehow.

@@ -460,25 +503,8 @@
schema:
type: "String"
arg: "path"
default: "misc/scala-devel/plugins"
default: ""
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another default to fix.

- choice: "compact"
- choice: "format"
- choice: "text+format"
description: "How to print trees when -Vprint is enabled. ([text],compact,format,text+format)"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was an example of not a simple rename. Document it.

@som-snytt
Copy link
Contributor Author

A paragraph at the top about the new prefixes, and common use cases for warnings and mild debugging that everyone should know. And maybe optimizer.

@SethTisue
Copy link
Member

SethTisue commented Jul 30, 2019

I assume this hasn't been merged yet because we're waiting for you to respond to your own review feedback :-)

Shall we go ahead and merge as-is, or are you planning further changes?

@som-snytt
Copy link
Contributor Author

I'll try to contribute improvements in a follow-up PR. I think this at least shows the options? Anyone still on 2.12 is probably no longer fiddling with their options.

@SethTisue SethTisue merged commit d492eda into scala:master Jul 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compiler option page is still for Scala 2.12
2 participants