Skip to content

Remove wrong information related to changes in float tokenisation. #1432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 22, 2019
Merged

Remove wrong information related to changes in float tokenisation. #1432

merged 2 commits into from
Jul 22, 2019

Conversation

johnkjellberg
Copy link
Contributor

1. is not a valid token, therefore the parentheses is not needed.

@Philippus
Copy link
Member

Nice find! Would you mind making this change for the translated tours as well to keep them more in sync?

@johnkjellberg
Copy link
Contributor Author

Nice find! Would you mind making this change for the translated tours as well to keep them more in sync?

I did the changes to all languages now. It seemed to have failed for some unknown reason though. A glitch?

Philippus
Philippus approved these changes Jul 15, 2019
View reviewed changes
Copy link
Member

@Philippus Philippus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I think the build failure is unrelated. I'll add the failing link to #1421.

@Philippus Philippus mentioned this pull request Jul 15, 2019
Closed
@SethTisue SethTisue merged commit cd954bc into scala:master Jul 22, 2019
@SethTisue
Copy link
Member

thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Philippus Philippus Philippus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@johnkjellberg @Philippus @SethTisue