Skip to content

Tweak literal types spec part about asInstanceOf #1418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 8, 2019
Merged

Tweak literal types spec part about asInstanceOf #1418

merged 1 commit into from
Jul 8, 2019

Conversation

dwijnand
Copy link
Member

@dwijnand dwijnand commented Jul 4, 2019

Feedback welcome.

@dwijnand dwijnand requested a review from milessabin July 4, 2019 17:17
@dwijnand dwijnand mentioned this pull request Jul 4, 2019
Closed
@sjrd
Copy link
Member

sjrd commented Jul 4, 2019

Should we add some dedicated note about asInstanceOf, maybe? In addition to removing the existing incorrect wording.

milessabin
milessabin approved these changes Jul 5, 2019
View reviewed changes
Copy link
Contributor

@milessabin milessabin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dwijnand dwijnand force-pushed the asInstanceOf-is-god-mode branch from 3a36bd6 to 4f0e54b Compare July 8, 2019 07:16
@dwijnand dwijnand requested a review from sjrd July 8, 2019 07:17
@dwijnand dwijnand merged commit 3729523 into scala:master Jul 8, 2019
@dwijnand dwijnand deleted the asInstanceOf-is-god-mode branch July 8, 2019 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milessabin milessabin milessabin approved these changes

@sjrd sjrd sjrd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dwijnand @sjrd @milessabin