Skip to content

Add Japanese translation of scala-for-java-programmers #1416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 11, 2019

Conversation

exoego
Copy link
Contributor

@exoego exoego commented Jul 4, 2019

Add Japanese translations of Scala for Java Programmers

@exoego exoego force-pushed the ja/for-java-programmers branch 6 times, most recently from 2a867ac to aab8bda Compare July 5, 2019 06:30
@exoego
Copy link
Contributor Author

exoego commented Jul 5, 2019

It looks like that ja for japanese in a phrase "scala-for-javaprogrammers" is removed somehow and makes the link broken...

- ./_site/tutorials/scala-for-java-programmers.html
  *  internally linking to /ja/tutorials/scala-for-va-programmers.html, which does not exist (line 1110)
<a href="/ja/tutorials/scala-for-va-programmers.html" class="lang">日本語</a>

This accidental removal of ja happens only in the original (English) page.

EDIT: It is fixed in a57151e

@exoego exoego force-pushed the ja/for-java-programmers branch from a57151e to 8e41720 Compare July 5, 2019 11:26
@exoego
Copy link
Contributor Author

exoego commented Jul 11, 2019

@eed3si9n
Could you kindly review this?

@eed3si9n eed3si9n self-requested a review July 11, 2019 15:28
@eed3si9n
Copy link
Member

Of course :)

@exoego exoego force-pushed the ja/for-java-programmers branch from 8e41720 to eb999c8 Compare July 11, 2019 22:23
@eed3si9n eed3si9n merged commit 56724a5 into scala:master Jul 11, 2019
@exoego exoego deleted the ja/for-java-programmers branch July 11, 2019 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants