Skip to content

Fix typos #1355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 18, 2019
Merged

Fix typos #1355

merged 1 commit into from
Jun 18, 2019

Conversation

asakaev
Copy link
Contributor

@asakaev asakaev commented Jun 8, 2019

No description provided.

@SethTisue
Copy link
Member

SethTisue commented Jun 9, 2019

LGTM except for the apostrophe changes.

in typography, it's standard practice to prefer a "curly" apostrophe and never use the "straight" one (see e.g. https://typographyforlawyers.com/straight-and-curly-quotes.html), so that part seems like a step backwards to me.

@dwijnand
Copy link
Member

dwijnand commented Jun 9, 2019

Similarly, the change from em-dash to hyphen-minus is a regression in my eyes.

@asakaev
Copy link
Contributor Author

asakaev commented Jun 9, 2019

@SethTisue Thanks for the English typography. I did not know about apostrophes, a very interesting book.
@dwijnand It was not hyphen-minus but em-dash symbol, but I will do it in the next PR.

@ashawley
Copy link
Member

ashawley commented Jun 9, 2019

Looking at the HTML output from Jekyll, it seems it gets the typography folks desire here when you use the ASCII straight apostrophe, double quotes, or double hyphens for em dash.

@SethTisue SethTisue changed the title Fix typo Fix typos Jun 18, 2019
@SethTisue SethTisue merged commit ce85125 into scala:master Jun 18, 2019
@SethTisue
Copy link
Member

SethTisue commented Jun 18, 2019

I've updated the PR description to indicate that a lot more than just one typo got fixed :-)

Thanks @asakaev, this is awesome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants