Skip to content

Add page on generating Scaladoc #1353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 2, 2019
Merged

Add page on generating Scaladoc #1353

merged 3 commits into from
Jul 2, 2019

Conversation

ashawley
Copy link
Member

@ashawley ashawley commented Jun 7, 2019

Despite appearances, it seems there weren't any notes on how to generate Scaladoc. People were piecing it together from the Scaladoc man page and the sbt documentation. This adds a minimal how-to page for both.

Copy link
Member

@dwijnand dwijnand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A joy to review. Looks great. Just two suggested changes.

@dwijnand
Copy link
Member

dwijnand commented Jun 9, 2019

Looks like you force pushed the current HEAD of master to your https://github.com/ashawley/docs.scala-lang/tree/scaladoc branch, which caused the PR to close.

@ashawley ashawley reopened this Jun 9, 2019
@ashawley
Copy link
Member Author

ashawley commented Jun 9, 2019

My mistake, so I did. Didn't know that would cause it to close.

@julienrf julienrf merged commit 9433228 into scala:master Jul 2, 2019
@ashawley ashawley deleted the scaladoc branch July 3, 2019 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants