Skip to content

Fix Chinese Simple(zh_CN) version of issue#1339 #1340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 30, 2019
Merged

Fix Chinese Simple(zh_CN) version of issue#1339 #1340

merged 1 commit into from
May 30, 2019

Conversation

dongxuwang
Copy link
Member

@dongxuwang dongxuwang commented May 30, 2019 •
edited by dwijnand
Loading

Refs #1339

dwijnand
dwijnand approved these changes May 30, 2019
View reviewed changes
Copy link
Member

@dwijnand dwijnand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't vouch for the Chinese part (I don't speak Chinese). But the rest LGTM :)

liufengyun
liufengyun approved these changes May 30, 2019
View reviewed changes
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dwijnand dwijnand merged commit 8b35576 into scala:master May 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwijnand dwijnand dwijnand approved these changes

@liufengyun liufengyun liufengyun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dongxuwang @dwijnand @liufengyun