Tweak Seq migration guide #1333
Merged
+81
−36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwijnand
commented
May 21, 2019
|
Polling for what names we should use for Seqs: https://www.strawpoll.me/18027945 |
szeiger
reviewed
May 21, 2019
|
LOL |
NthPortal
reviewed
May 22, 2019
|
|
||
| If you're making a library intended to be used by other programmers, then using `scala.Seq`, `scala.IndexedSeq`, or vararg is going to be a breaking change in the API semantics. For example, if there was a function `def orderFood(order: Seq[Order]): Seq[Food]`, previously the library user would have been able to pass in an array of `Order`, but it won't work for 2.13. | ||
| This also has the effect of making the type of varargs parameters immutable sequences, due to [SLS 6.6][], so in |
There was a problem hiding this comment.
a few issues:
- change from plural to singular ("These changes require" => "This [...] has")
- no previous effects were mentioned, so the word "also" is confusing
- unqualified "this" - "this change" would be a little better (this one is rather nitpicky and mostly channeling my high school english teacher)
There was a problem hiding this comment.
The only change I didn't apply is the "also" part. Do you think it's not obvious to the reader the immediate impact of changing the alias? We can fix this up still.
NthPortal
reviewed
May 22, 2019
NthPortal
reviewed
May 22, 2019
|
this is super. (and, I like the decision to not introduce |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.