Skip to content

Update getting-started-with-scala-in-intellij.md #1331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 26, 2019

Conversation

suyash1
Copy link
Contributor

@suyash1 suyash1 commented May 18, 2019

updating doc for adding scala framework support addition which was missing earlier

updating doc for adding scala framework support addition which was missing earlier
Copy link
Member

@dwijnand dwijnand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a good addition. But, in alternative to giving the information in-line, should we try and have it in a preferring prerequisite section or a later troubleshooting section?

@@ -36,7 +36,7 @@ take a few minutes but subsequent projects can use the same SDK.
## Writing code

1. On the **Project** pane on the left, right-click `src` and select
**New** => **Scala class**.
**New** => **Scala class**. If you don't see **Scala class**, right-click on **HelloWorld** and click on **Add Framework Support...**, select **Scala** and proceed. If you see **Error: library is not specified**, you can either click donload button, or select the library path manually.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a typo in "download".

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
**New** => **Scala class**. If you don't see **Scala class**, right-click on **HelloWorld** and click on **Add Framework Support...**, select **Scala** and proceed. If you see **Error: library is not specified**, you can either click donload button, or select the library path manually.
**New** => **Scala class**. If you don't see **Scala class**, right-click on **HelloWorld** and click on **Add Framework Support...**, select **Scala** and proceed. If you see **Error: library is not specified**, you can either click download button, or select the library path manually.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed typo.
@dwijnand IMHO putting this change in prerequisite section will be better because any new installation will need this step.

@SethTisue
Copy link
Member

But, in alternative to giving the information in-line, should we try and have it in a preferring prerequisite section or a later troubleshooting section?

maybe if any more troubleshooting information ends up being added, we'll need to do that, but I think it's okay for now

@SethTisue SethTisue merged commit 4e4760e into scala:master May 26, 2019
@SethTisue
Copy link
Member

thank you @suyash1 and reviewers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants