Skip to content

Russian Collections introduction #1327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 8, 2019
Merged

Russian Collections introduction #1327

merged 1 commit into from
Jul 8, 2019

Conversation

kotobotov
Copy link
Contributor

new try

@SethTisue
Copy link
Member

can you suggest a Russian-speaking reviewer?

@kotobotov
Copy link
Contributor Author

maybe @agilesteel can help, he also had really good course on youtube about scala collections

agilesteel
agilesteel approved these changes Jun 18, 2019
View reviewed changes
Copy link
Contributor

@agilesteel agilesteel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's all good. It matches the content from the English version.

@SethTisue
Copy link
Member

before we merge, can you:

  • squash the commits?
  • verify whether the Gemfile.lock change is intentional?

@kotobotov
Copy link
Contributor Author

sure

@SethTisue SethTisue merged commit 2debd5c into scala:master Jul 8, 2019
@SethTisue
Copy link
Member

thank you!

@kotobotov kotobotov deleted the ru-collection-introduction branch July 8, 2019 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agilesteel agilesteel agilesteel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kotobotov @SethTisue @agilesteel