Skip to content

Update Spanish translation of basics.md #1322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 7, 2019
Merged

Conversation

gclaramunt
Copy link
Contributor

Spanish translation of Basic scala

@gclaramunt
Copy link
Contributor Author

Some details are missing (intro and fiddle run), I'll add them asap

@NthPortal NthPortal changed the title Update basics.md Update Spanish translation of basics.md May 2, 2019
@NthPortal
Copy link
Contributor

Thanks for doing this! I can't review it as I am not fluent, but it's definitely something we need more of ❤️

@gclaramunt
Copy link
Contributor Author

Who can review? I can ask someone who speak Spanish :)

@dwijnand
Copy link
Member

dwijnand commented May 5, 2019

Perhaps @diesalbla, @jvican, and/or @ignasi35 have some spare bandwidth?

Copy link
Contributor

@diesalbla diesalbla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments.
General changes:

  • Replace "palabra clave" (too direct translation of keyword) by "palabra reservada".
  • Use the singular form, in preference to the plural form.

diesalbla and others added 2 commits May 5, 2019 23:59
Co-Authored-By: gclaramunt <gabriel.claramunt@gmail.com>
@gclaramunt
Copy link
Contributor Author

Thanks for the review :)

Copy link
Contributor

@ignasi35 ignasi35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! I've left a couple of major comments and a handful of small typo fixes.

Co-Authored-By: gclaramunt <gabriel.claramunt@gmail.com>
gclaramunt added 2 commits May 6, 2019 13:46
Co-Authored-By: gclaramunt <gabriel.claramunt@gmail.com>
@gclaramunt
Copy link
Contributor Author

Ya le pase el corrector y en contre un par de tildes mas que faltaban.

@SethTisue SethTisue merged commit bf9e769 into scala:master May 7, 2019
@SethTisue
Copy link
Member

thanks all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants