-
Notifications
You must be signed in to change notification settings - Fork 1k
Copy the strawman FAQ as an overview page #1318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
5c1e0ee
to
fb973a8
Compare
|
||
The following table summarizes the breaking changes: | ||
|
||
| Description | Old Code | New Code | Automatic Migration Rule | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the table does not render well and it only has few entries, we could just replace table rows with paragraphs:
### Operation `to[C[_]]`
Operation `to[C[_]]` has been removed.
Scala 2.12 code:
```scala
xs.to[List]
```
Scala 2.13 code:
```scala
xs.to(List)
```
Automatic migration rules: `Collection213Upgrade` and `Collections213CrossCompat`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i left the tables for now. not sure what's the best way to fix it... is there something like a scroll-div we can use? for code blocks that is done automatically.
I know that this doc isn't in the best possible shpae yet, but I'd suggest to not go too deep right now and refine it once it's merged. It's useful to have a stable link to what we have now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The content looks good, but we should make sure the page renders well before we publish it.
Agreed. I'll give it a try. |
Added some |
It works but the right columns are not easily discovered. We can improve that later, though. |
I changed the FAQ to point to the scala-lang page (https://github.com/scala/collection-strawman/wiki/FAQ) |
I updated the link at https://github.com/scala/scala/releases/tag/v2.13.0-RC1 |
This creates a 1:1 copy of https://github.com/scala/collection-strawman/wiki/FAQ with the goal to have a stable URL for the document. Follow-up changes are required: some content is outdated, issues with the layout (the tables are too wide).