Skip to content

Copy the strawman FAQ as an overview page #1318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 30, 2019

Conversation

lrytz
Copy link
Member

@lrytz lrytz commented Apr 26, 2019

This creates a 1:1 copy of https://github.com/scala/collection-strawman/wiki/FAQ with the goal to have a stable URL for the document. Follow-up changes are required: some content is outdated, issues with the layout (the tables are too wide).

image

@lrytz lrytz requested a review from julienrf April 26, 2019 09:30
@lrytz lrytz force-pushed the collections-migration-213 branch from 5c1e0ee to fb973a8 Compare April 26, 2019 09:32

The following table summarizes the breaking changes:

| Description | Old Code | New Code | Automatic Migration Rule |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the table does not render well and it only has few entries, we could just replace table rows with paragraphs:

### Operation `to[C[_]]`

Operation `to[C[_]]` has been removed.

Scala 2.12 code:

```scala
xs.to[List]
```

Scala 2.13 code:

```scala
xs.to(List)
```

Automatic migration rules: `Collection213Upgrade` and `Collections213CrossCompat`

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i left the tables for now. not sure what's the best way to fix it... is there something like a scroll-div we can use? for code blocks that is done automatically.

@lrytz
Copy link
Member Author

lrytz commented Apr 29, 2019

I know that this doc isn't in the best possible shpae yet, but I'd suggest to not go too deep right now and refine it once it's merged. It's useful to have a stable link to what we have now.

Copy link
Contributor

@julienrf julienrf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The content looks good, but we should make sure the page renders well before we publish it.

@lrytz
Copy link
Member Author

lrytz commented Apr 29, 2019

Agreed. I'll give it a try.

@lrytz
Copy link
Member Author

lrytz commented Apr 29, 2019

Added some div wrapper to allow scrolling - wdyt?
https://www.youtube.com/watch?v=WqB_aHKzVLA

@julienrf
Copy link
Contributor

It works but the right columns are not easily discovered. We can improve that later, though.

@lrytz lrytz merged commit 1e0fdda into scala:master Apr 30, 2019
@lrytz
Copy link
Member Author

lrytz commented Apr 30, 2019

I changed the FAQ to point to the scala-lang page (https://github.com/scala/collection-strawman/wiki/FAQ)

@SethTisue
Copy link
Member

I updated the link at https://github.com/scala/scala/releases/tag/v2.13.0-RC1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants