Skip to content

add JDK 12 info to JDK compat page #1292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 4, 2019
Merged

add JDK 12 info to JDK compat page #1292

merged 1 commit into from
Mar 4, 2019

Conversation

SethTisue
Copy link
Member

@SethTisue SethTisue commented Mar 1, 2019 •
edited
Loading

dwijnand
dwijnand approved these changes Mar 1, 2019
View reviewed changes
Copy link
Member

@dwijnand dwijnand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

You've added specific details that will have to be updated ("A release date for 2.12.9 has not been set"), but I can see it being useful (and a chance to mention nightly build usage).

@SethTisue
Copy link
Member Author

You've added specific details that will have to be updated

I've now set a monthly reminder in OmniFocus to check it and update if needed.

@SethTisue SethTisue merged commit f0f47c5 into scala:master Mar 4, 2019
@SethTisue
Copy link
Member Author

thank you @xuwei-k for your early attention to this

@SethTisue SethTisue deleted the jdk12 branch March 4, 2019 21:31
@SethTisue
Copy link
Member Author

followup: #1315

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwijnand dwijnand dwijnand approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SethTisue @dwijnand