Skip to content

Collection diagrams #1167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Oct 10, 2018
Merged

Collection diagrams #1167

merged 11 commits into from
Oct 10, 2018

Conversation

rkoeninger
Copy link
Contributor

@rkoeninger rkoeninger commented Oct 9, 2018

Fixes #1162
Fixes #1104

This PR was started to address an issue with BitSet not being shown in the correct spot in the class hierarchy on the collections FAQ page (it became a subtype of SortedSet instead of Set in Scala 2.10).

Text and the ascii-art chart on that page were updated.

The images appeared to be made with graphviz, but could not find source graphs. Made new .dot files to generate these images under /resources/images/tour/ where a couple of pre-existing .dot files were located. Also added entries to the Makefile that was in that folder. Committed the generated .svg files and linked to them from the above mentioned FAQ page. Images are now much cleaner looking, maintainable and make use of the site's established color palette.

(also fixed mutable collections diagram to address #1104 and referenced in new diagrams on collections overview page)

Previous appearance:

image

New appearance:

image

@SethTisue SethTisue merged commit 0202987 into scala:master Oct 10, 2018
@SethTisue
Copy link
Member

wow, fantastic, thank you so much for tackling this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BitSet hierarchy documentation inconsistent A mutable TreeMap is missing in collections overview.
2 participants