Skip to content

Improve JDK 9/10 compatibility notes visibility #1143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 17, 2018
Merged

Improve JDK 9/10 compatibility notes visibility #1143

merged 1 commit into from
Sep 17, 2018

Conversation

Jacoby6000
Copy link
Contributor

For somebody just glancing at this doc, it's way too easy to miss the note at the bottom. This adds the note in the table and makes it easier to see.

For somebody just glancing at this doc, it's way too easy to miss the note at the bottom. This adds the note in the table and makes it easier to see.
@Jacoby6000
Copy link
Contributor Author

Jacoby6000 commented Sep 11, 2018

Also, this makes me wonder. Does Scala 2.10 not also have this problem? Seems strange that compatibility would decrease between 2.10 and 2.11.

Copy link
Member

@SethTisue SethTisue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the improvement

@SethTisue
Copy link
Member

SethTisue commented Sep 11, 2018

Does Scala 2.10 not also have this problem? Seems strange that compatibility would decrease between 2.10 and 2.11

I agree that wording isn't as clear as it should be. There was no decrease in compatibility between 2.10 and 2.11.

(Not enforcing module constraints isn't so much a "problem" as simply an enhancement that hasn't happened yet, IMO.)

Anyway, as far as I can tell, the reason it says "2.11.12 and 2.12.6" is to attempt to imply that the situation may improve in the future in the 2.11.x and 2.12.x series, but it isn't likely to improve in the 2.10.x series.

But actually, it isn't likely to improve any further in the 2.11.x series, either, unless some new breakage on 9/10/11 is discovered. There are no definite plans for any further 2.11.x releases at all, and even if another 2.11.x release does end up happening for some reason, we'd be extremely conservative about what'd we accept for it, I doubt that work on enforcing module constraints would make the cut.

/cc @retronym

@SethTisue
Copy link
Member

@Jacoby6000 does that make you want to tweak this any further, or should I merge as-is?

@Jacoby6000
Copy link
Contributor Author

Jacoby6000 commented Sep 17, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants