Use jQuery from CDN, fall back to local if needed #1103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Philippus
changed the title
|
Thanks so much for doing this!! |
NthPortal
reviewed
Jul 18, 2018
_includes/footer.html
Outdated
| @@ -21,7 +21,8 @@ | |||
| </footer> | |||
|
|
|||
| <!-- jquery --> | |||
| <script src="https://ajax.googleapis.com/ajax/libs/jquery/3.1.1/jquery.min.js"></script> | |||
| <script src="https://cdnjs.cloudflare.com/ajax/libs/jquery/3.1.1/jquery.min.js" integrity="sha384-3ceskX3iaEnIogmQchP8opvBy3Mi7Ce34nWjpBIwVTHfGYWQS9jwHDVRnpKKHJg7" crossorigin="anonymous"></script> | |||
| <script>(window.jQuery) || document.write('<script src="/scripts/jquery.3.1.1.js"><\/script>');</script> | |||
There was a problem hiding this comment.
The only thing I'm wondering is if this needs to be src="{{ site.baseurl }}/scripts/jquery.3.1.1.js", but I don't really know enough about jekyll to answer that for sure
Philippus
force-pushed
the
jquery-fallback
branch
2 times, most recently
from
637e752 to
473acd0
Compare
Philippus
force-pushed
the
jquery-fallback
branch
from
473acd0 to
5a6710b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented the change suggested by @NthPortal.