Run testSuiteEx with SmallestModules as well #4624
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjrd
requested changes
Jan 15, 2022
Jenkinsfile
Outdated
| sbtretry ++$scala \ | ||
| 'set scalaJSLinkerConfig in testSuiteEx.v$v ~= (_.withModuleSplitStyle(ModuleSplitStyle.SmallestModules))' \ | ||
| 'set scalaJSLinkerConfig in testSuiteEx.v$v ~= (_.withModuleKind(ModuleKind.ESModule))' \ | ||
| testSuiteEx/test && |
There was a problem hiding this comment.
It looks like there is a stray tab character here:
Suggested change
| testSuiteEx/test && | |
| testSuiteEx/test && |
gzm0
force-pushed
the
test-suite-ex-split
branch
from
7587aec to
d57968f
Compare
Probably a good idea in any case. Notably to check analysis of getSuperclass. Discovered while working on scala-js#4616.
gzm0
force-pushed
the
test-suite-ex-split
branch
from
d57968f to
6ed2131
Compare
sjrd
approved these changes
Jan 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Probably a good idea in any case. Notably to check analysis of
getSuperclass.
Discovered while working on #4616.