Announcing Scala.js 1.13.0. #598
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gzm0
requested changes
Jan 25, 2023
|
All good points. Updated. |
gzm0
requested changes
Jan 26, 2023
| } | ||
| {% endhighlight %} | ||
|
|
||
| In some rare situations, this may turn code that appeared to work into actively throwing an exception. |
There was a problem hiding this comment.
This sentence is very misleading now that it is after the config block. Have you considered moving it up.
As other undefined behavior errors, they will be reported as UndefinedBehaviorErrors in fastLink mode, and unchecked in fullLink mode.
In some rare situations, this may turn code that appeared to work into actively throwing an exception.
Further, these additional checks can and will slow down fastLink-generated code.
Benchmarks show slowdowns of anywhere between 0% and 17%.
There was a problem hiding this comment.
Ah yes indeed, ouch. I amended it as you suggested.
gzm0
approved these changes
Jan 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For release tomorrow, if the reviews are fine by then.