Update JSDOM, improve CI infrastructure #53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
armanbilge
commented
Jun 1, 2022
armanbilge
commented
- Update JSDOM, cache in CI
- Update Node version used in CI
- Configure dependabot
sjrd
requested changes
Jun 2, 2022
build.sbt
Outdated
| UseRef.Public("actions", "setup-node", "v3"), | ||
| name = Some("Setup NodeJS v16 LTS"), | ||
| params = Map("node-version" -> "16", "cache" -> "npm"), | ||
| cond = Some("matrix.ci == 'ciNode' || matrix.ci == 'ciJSDOMNodeJS'") |
There was a problem hiding this comment.
Suggested change
| cond = Some("matrix.ci == 'ciNode' || matrix.ci == 'ciJSDOMNodeJS'") | |
| cond = Some("matrix.ci == 'ciNode' || matrix.ci == 'ciJSDOMNodeJS'"), |
build.sbt
Outdated
| WorkflowStep.Run( | ||
| List("npm install"), | ||
| name = Some("Install jsdom"), | ||
| cond = Some("matrix.ci == 'ciJSDOMNodeJS'"))) | ||
| cond = Some("matrix.ci == 'ciJSDOMNodeJS'") |
There was a problem hiding this comment.
Suggested change
| cond = Some("matrix.ci == 'ciJSDOMNodeJS'") | |
| cond = Some("matrix.ci == 'ciJSDOMNodeJS'"), |
Comment on lines
+1
to
+6
| version: 2 | ||
| updates: | ||
| - package-ecosystem: "npm" | ||
| directory: "/" | ||
| schedule: | ||
| interval: "weekly" |
There was a problem hiding this comment.
This addition probably deserves a separate commit, at least.
armanbilge
force-pushed
the
update/js-dom-19.0.0
branch
from
2bb64f0 to
b9281be
Compare
|
Thanks for the review. If you'll merge my PRs, I'm happy to do things your way :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.