-
Notifications
You must be signed in to change notification settings - Fork 161
Audio API changes #797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
yilinwei
wants to merge
42
commits into
scala-js:main
Choose a base branch
from
yilinwei:base-audio
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Audio API changes #797
Changes from 3 commits
Commits
Show all changes
42 commits
Select commit
Hold shift + click to select a range
4f524b8
backup
yilinwei 8b1d132
backup
yilinwei b44eaa8
backup
yilinwei 2aaf2ed
Switch back to using traits for now.
yilinwei b91df37
typo.
yilinwei a4edff5
Switch encoding for mima.
yilinwei 9887ce0
Check-in API report
yilinwei 081534d
BlobEvent and MediaRecorder.
zainab-ali fca6713
Make sure `BlobEvent` is class.
yilinwei 4dda4bf
`data` is required.
yilinwei a4cfb9a
Add `AudioWorkletNode` and associated options.
yilinwei 0099ad3
Add `Worklet` and `AudioWorklet`.
yilinwei e8b3650
Fix signature
yilinwei 1178935
Add `AudioParamDescriptor`.
yilinwei fdb9aad
Add `defaultValue` for `AudioParamDescriptor`.
yilinwei c067de2
Make sure to extend `js.Object`.
yilinwei ba8f619
Add `AudioWorkletGlobalScope`.
yilinwei 3e32f25
`AudioWorkletNode` should not be abstract.
yilinwei 42275a7
Make `ReadOnlyMapLike` extend `js.Iterable`.
yilinwei 0e90800
`self` does not yet exist within the `Worklet` contexts.
yilinwei f860eaa
Correct `ReadOnlyMapLike` signature `forEach`.
yilinwei b548118
Add docs.
zainab-ali 2d1f240
Add docs.
zainab-ali f7adab3
Doc improvements.
zainab-ali 56d513b
Add js.native annotation to AudioParamAutomationRate.
zainab-ali 6781565
More docs.
zainab-ali 7d6eb4e
Add js.native annotation to AudioTimestamp.
zainab-ali d159170
Correct type of params for AudioWorkletProcessor.
zainab-ali 3bac38d
WorkletOptions should extend js.Object.
zainab-ali e32a80c
Add MediaRecorder and options.
zainab-ali c221e2b
Correct scaladoc.
zainab-ali 824092d
Api reports.
zainab-ali e637830
AudioWorkletGlobalScope should be an abstract class.
zainab-ali 314c67b
AudioScheduledSourceNode should be an abstract class.
zainab-ali 9923b6b
MediaElementAudioSourceNode mediaElement should be a def.
zainab-ali 98af177
Regenerate api reports.
zainab-ali 18a6f7d
Add docs for ReadOnlyMapLike.
zainab-ali df8e9cf
Reformat doc comments.
zainab-ali 523266a
Remove redundant comment.
zainab-ali 07dcf43
Remove channelCount, channelCountMode and channelInterpretation.
zainab-ali b3a694e
Refactor enums for Scala 3.
zainab-ali e305129
Regenerate API reports.
zainab-ali File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 changes: 20 additions & 0 deletions
20
dom/src/main/scala/org/scalajs/dom/AudioBufferSourceNodeOptions.scala
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
/** Documentation is thanks to Mozilla Contributors at https://developer.mozilla.org/en-US/docs/Web/API and available | ||
* under the Creative Commons Attribution-ShareAlike v2.5 or later. http://creativecommons.org/licenses/by-sa/2.5/ | ||
* | ||
* Everything else is under the MIT License http://opensource.org/licenses/MIT | ||
*/ | ||
package org.scalajs.dom | ||
|
||
import scala.scalajs.js | ||
|
||
trait AudioBufferSourceNodeOptions extends js.Object { | ||
var buffer: js.UndefOr[AudioBuffer] = js.undefined | ||
var loop: js.UndefOr[Boolean] = js.undefined | ||
var loopStart: js.UndefOr[Double] = js.undefined | ||
var loopEnd: js.UndefOr[Double] = js.undefined | ||
var detune: js.UndefOr[Double] = js.undefined | ||
var playbackRate: js.UndefOr[Double] = js.undefined | ||
var channelCount: js.UndefOr[Int] = js.undefined | ||
var channelCountMode: js.UndefOr[AudioNodeChannelCountMode] = js.undefined | ||
var channelInterpretation: js.UndefOr[AudioNodeChannelInterpretation] = js.undefined | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 changes: 17 additions & 0 deletions
17
dom/src/main/scala/org/scalajs/dom/AudioNodeChannelCountMode.scala
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
/** Documentation is thanks to Mozilla Contributors at https://developer.mozilla.org/en-US/docs/Web/API and available | ||
* under the Creative Commons Attribution-ShareAlike v2.5 or later. http://creativecommons.org/licenses/by-sa/2.5/ | ||
* | ||
* Everything else is under the MIT License http://opensource.org/licenses/MIT | ||
*/ | ||
package org.scalajs.dom | ||
|
||
import scala.scalajs.js | ||
|
||
@js.native | ||
sealed trait AudioNodeChannelCountMode extends js.Any | ||
zetashift marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
object AudioNodeChannelCountMode { | ||
val max: AudioNodeChannelCountMode = "max".asInstanceOf[AudioNodeChannelCountMode] | ||
val `clamped-max`: AudioNodeChannelCountMode = "clamped-max".asInstanceOf[AudioNodeChannelCountMode] | ||
val explicit: AudioNodeChannelCountMode = "explicit".asInstanceOf[AudioNodeChannelCountMode] | ||
} |
16 changes: 16 additions & 0 deletions
16
dom/src/main/scala/org/scalajs/dom/AudioNodeChannelInterpretation.scala
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
/** Documentation is thanks to Mozilla Contributors at https://developer.mozilla.org/en-US/docs/Web/API and available | ||
* under the Creative Commons Attribution-ShareAlike v2.5 or later. http://creativecommons.org/licenses/by-sa/2.5/ | ||
* | ||
* Everything else is under the MIT License http://opensource.org/licenses/MIT | ||
*/ | ||
package org.scalajs.dom | ||
|
||
import scala.scalajs.js | ||
|
||
@js.native | ||
sealed trait AudioNodeChannelInterpretation extends js.Any | ||
|
||
object AudioNodeChannelInterpretation { | ||
val speakers: AudioNodeChannelInterpretation = "speakers".asInstanceOf[AudioNodeChannelInterpretation] | ||
val discrete: AudioNodeChannelInterpretation = "discrete".asInstanceOf[AudioNodeChannelInterpretation] | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
28 changes: 28 additions & 0 deletions
28
dom/src/main/scala/org/scalajs/dom/AudioScheduledSourceNode.scala
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
/** Documentation is thanks to Mozilla Contributors at https://developer.mozilla.org/en-US/docs/Web/API and available | ||
* under the Creative Commons Attribution-ShareAlike v2.5 or later. http://creativecommons.org/licenses/by-sa/2.5/ | ||
* | ||
* Everything else is under the MIT License http://opensource.org/licenses/MIT | ||
*/ | ||
package org.scalajs.dom | ||
|
||
import scala.scalajs.js | ||
|
||
@js.native | ||
trait AudioScheduledSourceNode extends AudioNode { | ||
|
||
/** This method specifies the exact time to start playing the tone. */ | ||
def start(): Unit = js.native | ||
|
||
/** This method specifies the exact time to stop playing the tone. */ | ||
def stop(): Unit = js.native | ||
|
||
/** This method specifies the exact time to start playing the tone. */ | ||
def start(when: Double): Unit = js.native | ||
|
||
/** This method specifies the exact time to stop playing the tone. */ | ||
def stop(when: Double): Unit = js.native | ||
|
||
/** Used to set the event handler for the ended event, which fires when the tone has stopped playing. */ | ||
var onended: js.Function1[Event, _] = js.native | ||
|
||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
/** Documentation is thanks to Mozilla Contributors at https://developer.mozilla.org/en-US/docs/Web/API and available | ||
* under the Creative Commons Attribution-ShareAlike v2.5 or later. http://creativecommons.org/licenses/by-sa/2.5/ | ||
* | ||
* Everything else is under the MIT License http://opensource.org/licenses/MIT | ||
*/ | ||
package org.scalajs.dom | ||
|
||
import scala.scalajs.js | ||
|
||
trait AudioTimestamp extends js.Object { | ||
var contextTime: Double | ||
var performanceTime: Double | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.