Skip to content

Minor improvements #464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 10, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,10 @@ jobs:
SCALAJS_VERSION: "${{ matrix.scalajsversion == '0.6.x' && '0.6.28' || '' }}"
steps:
- uses: actions/checkout@v2
- uses: olafurpg/setup-scala@v10
- uses: olafurpg/setup-scala@v13
with:
java-version: "adopt@1.8"
- uses: coursier/cache-action@v5
- uses: coursier/cache-action@v6
- name: Build
run: sbt "++${{ matrix.scalaversion }}" package
- name: Test generate documentation
Expand All @@ -37,9 +37,9 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: olafurpg/setup-scala@v10
- uses: olafurpg/setup-scala@v13
with:
java-version: "adopt@1.8"
- uses: coursier/cache-action@v5
- uses: coursier/cache-action@v6
- name: Readme generation
run: sbt readme/run
4 changes: 2 additions & 2 deletions .github/workflows/ghpages.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,10 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: olafurpg/setup-scala@v10
- uses: olafurpg/setup-scala@v13
with:
java-version: "adopt@1.8"
- uses: coursier/cache-action@v5
- uses: coursier/cache-action@v6

- name: Build
run: sbt readme/run
Expand Down
11 changes: 8 additions & 3 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,7 +1,12 @@
target/
.bloop
.bsp
.cache
.classpath
.idea
.idea_modules
.metals
.project
.settings/
.idea
.idea_modules
.vscode
metals.sbt
target/
Comment on lines +10 to +12
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes!! lol

10 changes: 10 additions & 0 deletions build.sbt
Original file line number Diff line number Diff line change
Expand Up @@ -75,11 +75,21 @@ publishTo := {

pomExtra := (
<developers>
<developer>
<id>japgolly</id>
<name>David Barri</name>
<url>https://github.com/japgolly</url>
</developer>
<developer>
<id>lihaoyi</id>
<name>Li Haoyi</name>
<url>https://github.com/lihaoyi/</url>
</developer>
<developer>
<id>armanbilge</id>
<name>Arman Bilge</name>
<url>https://github.com/armanbilge</url>
</developer>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wtf? Sorry about the order @armanbilge . No one cares but it's still weird and unintentional

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol yeah I'm surprised I made 3rd ;) no worries, cool to have my name among the giants!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nah man, it's cos I copy-pasted the top one (lihaoyi) twice and then modified but it seems I ended up modifying instance 2 instead of 3. Sorry lol. Doesn't matter anway

<developer>
<id>sjrd</id>
<name>Sébastien Doeraene</name>
Expand Down
File renamed without changes.