-
Notifications
You must be signed in to change notification settings - Fork 161
Support scala 3 #446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support scala 3 #446
Changes from 10 commits
344bb13
ad63fe5
5910767
5079836
d8abc03
4397c7b
bf33bf1
f561225
0425741
9606d60
28eeb7d
3c0e714
d15c21b
7d70b3d
ea04026
b8c4311
47cc047
fb8188a
d70eaa0
f594b66
5176b44
f77e53a
ed3ad20
0432c8f
cf5e4e7
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
sbt.version=1.2.8 | ||
sbt.version=1.5.0-M2 |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,7 +11,8 @@ import scala.scalajs.js.annotation._ | |
*/ | ||
@js.native | ||
@JSGlobal | ||
class URL(url: String, base: String = js.native) extends js.Object { | ||
class URL(url: String, base: String) extends js.Object { | ||
def this(url: String) = this(url, js.native) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why is this necessary? If the original code is not accepted by Scala 3, please report an issue to the dotty repo, because that's a bug. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah the original would not compile in 3.0.0-RC1 - I will report. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Created: |
||
|
||
/** | ||
* Returns a DOMString containing the origin of the URL, that is its scheme, | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,8 @@ | ||
package org.scalajs.dom | ||
|
||
import scala.language.implicitConversions | ||
|
||
Comment on lines
3
to
-4
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please keep this empty line. We always keep |
||
import scala.collection.mutable | ||
import scala.runtime.RichDouble | ||
|
||
package object ext { | ||
|
||
|
@@ -22,17 +22,18 @@ package object ext { | |
def cast[T] = x.asInstanceOf[T] | ||
} | ||
|
||
implicit def pimpAnimatedNumber(x: svg.AnimatedNumber) = x.baseVal | ||
implicit def pimpAnimatedNumber(x: svg.AnimatedNumber): Double = x.baseVal | ||
|
||
implicit def pimpRichAnimatedNumber(x: svg.AnimatedNumber) = | ||
implicit def pimpRichAnimatedNumber(x: svg.AnimatedNumber): RichDouble = | ||
x.baseVal: runtime.RichDouble | ||
|
||
implicit def pimpAnimatedLength(x: svg.AnimatedLength) = x.baseVal.value | ||
implicit def pimpAnimatedLength(x: svg.AnimatedLength): Double = | ||
x.baseVal.value | ||
|
||
implicit def pimpRichAnimatedLength(x: svg.AnimatedLength) = | ||
implicit def pimpRichAnimatedLength(x: svg.AnimatedLength): RichDouble = | ||
x.baseVal.value: runtime.RichDouble | ||
|
||
implicit def color2String(c: Color) = c.toString | ||
implicit def color2String(c: Color): String = c.toString | ||
implicit class pimpedContext(val ctx: CanvasRenderingContext2D) { | ||
def prepCircle(x: Double, y: Double, r: Double) = { | ||
ctx.beginPath() | ||
|
Uh oh!
There was an error while loading. Please reload this page.