Skip to content

Fix #411: Make dom.console work in web workers. #412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 10, 2020
Merged

Fix #411: Make dom.console work in web workers. #412

merged 1 commit into from
Jun 10, 2020

Conversation

japgolly
Copy link
Contributor

No description provided.

sjrd
sjrd approved these changes Jun 10, 2020
View reviewed changes
Copy link
Member

@sjrd sjrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@sjrd sjrd changed the title Fix #411: console doesn't work in web workers Fix #411: Make dom.console work in web workers. Jun 10, 2020
@sjrd sjrd merged commit 1496242 into scala-js:master Jun 10, 2020
@exoego
Copy link
Contributor

exoego commented Jul 30, 2020

@sjrd
Could you publish new version for this change?
It helps Scala.js users to use console.log instead of heavier println.

@sjrd
Copy link
Member

sjrd commented Aug 8, 2020

Done (pending sync on Maven Central).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjrd sjrd sjrd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@japgolly @exoego @sjrd