Prepare for version 1.0.0. #397
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
sjrd
commented
Feb 7, 2020
sjrd
commented
- Bump the version number to 1.0.0-SNAPSHOT
- Remove all the deprecated things
gzm0
approved these changes
Feb 10, 2020
| type Document = raw.HTMLDocument | ||
| type Element = raw.HTMLElement | ||
| type Embed = raw.HTMLEmbedElement | ||
| type FieldSet = raw.HTMLFieldSetElement | ||
| @deprecated("Obsolete.", "HTML 4.01") | ||
| type Font = raw.HTMLFontElement |
There was a problem hiding this comment.
Do we actually want to remove these?
(Unsure about how scala-js-dom has handled this in the past, but just seems potentially problematic).
I think we do, yes. Those things might not work in browsers, and if you really want them, you can use |
|
OK, fair enough. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.