Skip to content

Fix wrong parameter names in CollatorOptions #386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 28, 2019
Merged

Fix wrong parameter names in CollatorOptions #386

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions src/main/scala/org/scalajs/dom/experimental/intl/Intl.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,8 @@ class NumberFormat(locales: String | js.Array[String],
trait CollatorOptions extends js.Object {
val localeMatcher: js.UndefOr[String]
val usage: js.UndefOr[String]
val sensivity: js.UndefOr[String]
val ignore­Punctua­tion: js.UndefOr[Boolean]
val sensitivity: js.UndefOr[String]
val ignorePunctuation: js.UndefOr[Boolean]
Copy link
Contributor Author

@exoego exoego Oct 26, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is weird.
Before this change, ignore­-Punctua­-tion was shown on my Intellij IDEA, so I fixed it to ignorePunctuation.
GitHub recognizes the change, but - is not shown here.

val numeric: js.UndefOr[Boolean]
val caseFirst: js.UndefOr[String]
}
Expand Down Expand Up @@ -94,7 +94,7 @@ object CollatorOptions {
* Examples: a ≠ b, a ≠ á, a ≠ A.
* The default is "variant" for usage "sort"; it's locale dependent for
* usage "search".
* @param ignore­Punctua­tion Whether punctuation should be ignored. Possible values are true
* @param ignorePunctuation Whether punctuation should be ignored. Possible values are true
* and false; the default is false.
* @param numeric Whether numeric collation should be used, such that "1" < "2" < "10".
* Possible values are true and false; the default is false.
Expand All @@ -114,17 +114,17 @@ object CollatorOptions {
def apply(
localeMatcher: js.UndefOr[String] = js.undefined,
usage: js.UndefOr[String] = js.undefined,
sensivity: js.UndefOr[String] = js.undefined,
ignore­Punctua­tion: js.UndefOr[Boolean] = js.undefined,
sensitivity: js.UndefOr[String] = js.undefined,
ignorePunctuation: js.UndefOr[Boolean] = js.undefined,
numeric: js.UndefOr[Boolean] = js.undefined,
caseFirst: js.UndefOr[String] = js.undefined
): CollatorOptions = {
js.Dynamic
.literal(
localeMatcher = localeMatcher,
usage = usage,
sensivity = sensivity,
ignore­Punctua­tion = ignore­Punctua­tion,
sensitivity = sensitivity,
ignorePunctuation = ignorePunctuation,
numeric = numeric,
caseFirst = caseFirst
)
Expand Down