Skip to content

Fix #384: Make locales optional in DateTimeFormat & NumberFormat. #385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 28, 2019
Merged

Fix #384: Make locales optional in DateTimeFormat & NumberFormat. #385

merged 1 commit into from
Oct 28, 2019

Conversation

exoego
Copy link
Contributor

@exoego exoego commented Oct 26, 2019

Fixes #384

@sjrd sjrd changed the title Make locales optional in DateTimeFormat & NumberFormat Fix #384: Make locales optional in DateTimeFormat & NumberFormat. Oct 28, 2019
@sjrd sjrd merged commit 140fd17 into scala-js:master Oct 28, 2019
@exoego exoego deleted the locale-parameter branch October 28, 2019 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjrd sjrd sjrd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The locales parameter of DateTimeFormat and NumberFormat should be optional
2 participants
@exoego @sjrd