Skip to content

Add experimental Storage API support. #378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 6, 2019
Merged

Conversation

exoego
Copy link
Contributor

@exoego exoego commented Sep 9, 2019

@exoego
Copy link
Contributor Author

exoego commented Dec 3, 2019

Is this project no longer maintained ?
If so, I will fork and publish.
Thanks for years of maintenance.


@js.native
trait NavigatorStorage extends js.Object {
val storage: js.UndefOr[StorageManager] = js.native
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this a js.UndefOr? IIUC the spec, this should always be define, shouldn't it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I initially thought that js.UndefOr allows user to detect the feature exists on browsers.
However, such feature detection can be achieved in other way.
So now removed js.UndefOr in 77276de as same as in other experimental API support (e.g. toWebRTC).

@sjrd
Copy link
Member

sjrd commented Dec 5, 2019

Is this project no longer maintained ?

It's maintained but it's not on the shortlist of projects that I continuously monitor. So if I don't find the time shortly after receiving the notification for some PR/comment/etc., things can get lost. :(

@sjrd sjrd merged commit 53498ee into scala-js:master Dec 6, 2019
@exoego exoego deleted the storage-api branch June 25, 2020 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: Storage API for persistent storage and quota estimates
2 participants