Mark deprecated/non-standard HTMLElement interfaces as deprecated #360
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exoego
force-pushed
the
deprecate-elements
branch
from
50d4244 to
9b294ab
Compare
|
I'd approve, but the CI didn't pass. |
exoego
force-pushed
the
deprecate-elements
branch
from
9b294ab to
9b5dca2
Compare
|
Fixed the missing |
sjrd
approved these changes
May 14, 2019
damercier
reviewed
Feb 13, 2020
| type BlockElement = raw.HTMLBlockElement | ||
| type Body = raw.HTMLBodyElement | ||
| type Button = raw.HTMLButtonElement | ||
| type BR = raw.HTMLBRElement | ||
| type Canvas = raw.HTMLCanvasElement | ||
| type Collection = raw.HTMLCollection | ||
| type DataList = raw.HTMLDataListElement | ||
| @deprecated("Non-standard.", "0.9.8") | ||
| type DD = raw.HTMLDDElement |
There was a problem hiding this comment.
Hello,
Why are the DD and DT considered non-standard?
Actually, this is valid HTML5 elements.
See: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/dd and https://www.w3.org/TR/html52/grouping-content.html#the-dt-element
Can we re-introduce those missing elements in the next release?
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #272