Skip to content

Fix #254: Correct signature of history navigation methods #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions src/main/scala/org/scalajs/dom/raw/lib.scala
Original file line number Diff line number Diff line change
Expand Up @@ -5146,8 +5146,6 @@ class History extends js.Object {
*/
def length: Int = js.native

def back(distance: js.Any): Unit = js.native

/**
* Goes to the previous page in session history, the same action as when the user clicks
* the browser's Back button. Equivalent to history.go(-1). Note: Calling this
Expand All @@ -5158,8 +5156,6 @@ class History extends js.Object {
*/
def back(): Unit = js.native

def forward(distance: js.Any): Unit = js.native

/**
* Goes to the next page in session history, the same action as when the user clicks the
* browser's Forward button; this is equivalent to history.go(1). Note: Calling
Expand All @@ -5170,7 +5166,7 @@ class History extends js.Object {
*/
def forward(): Unit = js.native

def go(delta: js.Any): Unit = js.native
def go(delta: Int): Unit = js.native

/**
* Loads a page from the session history, identified by its relative location to the
Expand Down