Update to the latest version in the docs #245
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjrd
requested changes
Oct 1, 2016
|
|
||
| @p | ||
| then enjoy the types available in @hl.scala{org.scalajs.dom}. scalajs-dom 0.9.0 is built and published for Scala.js 0.6.6 and later, with both Scala 2.10 and 2.11. | ||
| then enjoy the types available in @hl.scala{org.scalajs.dom}. scalajs-dom 0.9.1 is built and published for Scala.js 0.6.6 and later, with both Scala 2.10 and 2.11. |
There was a problem hiding this comment.
You should also change Scala.js 0.6.6 -> 0.6.8 in that case.
|
Done. Amended and force pushed. You can also squash using github UI before merging. Does that not produce wanted results? |
sjrd
approved these changes
Oct 6, 2016
|
No squashing from GitHub does not produce a merge commit. We want merge commits to identify groups of commits pertaining to a PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.