Skip to content

Add URL constructor #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 14, 2016
Merged

Add URL constructor #235

merged 1 commit into from
Jul 14, 2016

Conversation

turbolent
Copy link
Contributor

@sjrd
Copy link
Member

sjrd commented Jul 10, 2016

Given that the URL constructor does not seem to be supported in IE yet, this should go in the experimental package, in a file URL.scala. It's weird that the object URL and class URL won't live in the same package, but that reflects their respective level of support.

@sjrd
Copy link
Member

sjrd commented Jul 10, 2016

That's all.

@turbolent
Copy link
Contributor Author

Thanks for the feedback! Moved the class to the experimental package as suggested.

* MDN
*/
var hash: String = js.native
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a missing EOL at the end of the file here.

@sjrd
Copy link
Member

sjrd commented Jul 11, 2016

Otherwise good for me. Could you squash your commits into a single commit, please?

@turbolent
Copy link
Contributor Author

Squashed. You can also now do this straight from GitHub BTW: https://help.github.com/articles/about-pull-request-merge-squashing/

@sjrd
Copy link
Member

sjrd commented Jul 14, 2016

LGTM.

GitHub does not let me squash your commits and create a merge commit for merging the PR, unfortunately.

@sjrd sjrd merged commit 911f30f into scala-js:master Jul 14, 2016
@turbolent turbolent deleted the bastian/url-class branch July 14, 2016 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants