Skip to content

Fix #232: Fix the definition of URL and its static methods. #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 12, 2016
Merged

Fix #232: Fix the definition of URL and its static methods. #234

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/main/scala/org/scalajs/dom/package.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,6 @@ package object dom {
type NodeList = raw.NodeList
type NodeListOf[TNode <: Node] = raw.NodeListOf[TNode]

type ObjectURLOptions = raw.ObjectURLOptions
type OfflineAudioContext = raw.OfflineAudioContext
@deprecated(
"Use the promise version of OfflineAudioContext.startRendering instead.",
Expand Down Expand Up @@ -198,7 +197,7 @@ package object dom {
type TreeWalker = raw.TreeWalker

type UIEvent = raw.UIEvent
type URL = raw.URL
lazy val URL: raw.URL.type = raw.URL

type ValidityState = raw.ValidityState
type VisibilityState = raw.VisibilityState
Expand Down
13 changes: 3 additions & 10 deletions src/main/scala/org/scalajs/dom/raw/lib.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6067,11 +6067,6 @@ class ClientRectList extends DOMList[ClientRect]
@js.native
trait External extends js.Object

@js.native
trait ObjectURLOptions extends js.Object {
def oneTimeOnly: Boolean = js.native
}

/**
* The ErrorEvent interface represents events providing information related to
* errors in scripts or in files.
Expand Down Expand Up @@ -6584,13 +6579,12 @@ abstract class File extends Blob {
}

/**
* The URL interface represent an object providing static methods used for creating
* object URLs.
* The URL object provides static methods used for creating object URLs.
*
* MDN
*/
@js.native
trait URL extends js.Object {
object URL extends js.Object {

/**
* The URL.revokeObjectURL() static method releases an existing object URL which
Expand All @@ -6610,8 +6604,7 @@ trait URL extends js.Object {
*
* MDN
*/
def createObjectURL(`object`: js.Any,
options: ObjectURLOptions = js.native): String = js.native
def createObjectURL(blob: Blob): String = js.native
}

/**
Expand Down