Attributes + dependencies

[antonkulaga]

I added an implicit class for attributes and updated dependencies to scalajs 2.41

[lihaoyi]

I'm not a collections expert, but could you briefly describe why you need to extend both mutable.Map and mutable.MapLike? I would have thought the first would be sufficient for most purposes.

[antonkulaga]

Yes, you are right, MapLike is redundant here as Map already inherits from MapLike. Originally I was going to make it with maplike but then noticed that I can extend Map.

P.S. By the way, as I understand you also use intellij idea? For me the error highlightning is completely broken in scalajsdom but in the same time everything works. If you have the same, maybe it is worth opening an issue there?

[sjrd]

This is superfluous. The 2.10.x series are backward and forward binary compatible. There is no need to cross-compile against several versions in the same series.

[antonkulaga]

@sjrd , I deleted override for Empty and crosscompilation for 2.10.3 as you suggested (by the way, maybe it makes sens to delete cross-compilation for 2.11 milestones as 2.11RC3 is realeased?)

[sjrd]

We'll keep cross-compiling for 2.11 M7 and M8 until 2.11 final is out, because people may have come to develop their project in, say, 2.11.0-M8, and maybe don't want to upgrade every time a new RC is out.

[lihaoyi]

Are you using the sbt-idea plugin? IntelliJ's own sbt import borks everything, but sbt-idea's project gen looks fine.

The PR looks good to me, I'll leave it to @sjrd to merge it if he's happy with everything

[antonkulaga]

Are you using the sbt-idea plugin?

I use sbt-idea 1.6.0 with latest Intellij Idea. Probably there is a regression either in Idea or in sbt-idea plugin because it used to work fine.

[lihaoyi]

I've been using 1.5.2

[sjrd]

Ideally, the 4 commits should be squashed into a single one, since the last three "fix" the first one. Also, while you are at it, you could remove double blank lines (replace 2 consecutive blank lines by a single one).

[antonkulaga]

@sjrd check now, I have squashed them

[sjrd]

LGTM

[antonkulaga]

thank you