Skip to content

MediaQueryList.addListener has wrong type #851

Open
@matthughes

Description

@matthughes

MediaQueryList has an addListener function that takes a non-implementable (js.native) MediaQueryListListener instance. Instead it should take js.Function1[MediaQueryList, Any]

trait MediaQueryList extends js.Object {
  /** Adds a new listener to the media query list. If the specified listener is already in the list, this method has no
    * effect.
    */
  def addListener(listener: MediaQueryListListener): Unit = js.native
}

/** A MediaQueryList object maintains a list of media queries on a document, and handles sending notifications to
  * listeners when the media queries on the document change.
  */
@js.native
trait MediaQueryListListener extends js.Object {
  def apply(mql: MediaQueryList): Unit = js.native
}

This was discussed in Discord here: https://discord.com/channels/632150470000902164/635668814956068864/1255179308021059756

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions