Skip to content

uefi-raw: make padding more explicit #864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

phip1611
Copy link
Member

Make the padding more explicit.

Checklist

  • Sensible git history (for example, squash "typo" or "fix" commits). See the Rewriting History guide for help.
  • Update the changelog (if necessary)

@phip1611 phip1611 requested a review from nicholasbishop June 19, 2023 12:23
@nicholasbishop
Copy link
Member

We used to have that padding field, but took it out in #629

I think not having the padding field is fine, as this is a repr(C) struct and the C definition does not include an explicit padding field:
https://uefi.org/specs/UEFI/2.10/07_Services_Boot_Services.html#efi-boot-services-getmemorymap

Is there a particular reason why this struct should get explicit padding? (I'm sure there are lots of other structs in UEFI that have implicit padding too.)

@phip1611
Copy link
Member Author

phip1611 commented Jun 19, 2023

Not a specific reason. Just for better readability.

Consistency is more important, however. Either we should have explicit padding everywhere or not at all.

@phip1611 phip1611 closed this Jun 19, 2023
@phip1611 phip1611 deleted the mem-map-hint branch July 14, 2024 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants