Add RngProtocol to uefi-raw and use it from uefi
#778
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the first protocol interface added to uefi-raw, chosen because it's pretty simple. A couple naming notes: * For uefi-raw, I went with a more explicit `protocol` module name rather than `proto`. * Similarly, instead of naming the protocol `Rng` I named it `RngProtocol`. Unlike in the uefi crate, it doesn't implement a `Protocol` trait, so I think it makes sense to give it a longer name clearly indicating what it is.
This replaces much of the `Rng` implementation with stuff from uefi-raw.
phip1611
approved these changes
Apr 29, 2023
phip1611
approved these changes
Apr 29, 2023
|
Very nice. I like the new uefi-raw crate :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple naming notes:
protocolmodule name rather thanproto.RngI named itRngProtocol. Unlike in the uefi crate, it doesn't implement aProtocoltrait, so I think it makes sense to give it a longer name clearly indicating what it is.Should be no change to the public API of
uefifrom this, all internal changes.Checklist