Use the uguid crate to replace the Guid struct and guid! macro
#777
+19
−485
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phip1611
approved these changes
Apr 29, 2023
This should be mostly transparent for the end user except that the `from_values` method has been removed. Usually the `guid!` macro is a more convenient choice anyway, but `new` or `from_bytes` can also be used if needed. This allows us to delete a bit of code and some tests, as well as slightly reducing our dependency on proc macros as the `uguid::guid!` macro is a declarative macro.
phip1611
force-pushed
the
bishop-uguid-3
branch
from
2d236a2 to
5894e51
Compare
|
Nice, I like it. I can use this to use the same code for my UEFI and non-uefi code. Like ESRT parsing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
uguidcrate is something I open sourced at work. It can hopefully serve as a useful bit of shared vocabulary in the ecosystem for crates that need Windows-style GUIDs.This should be mostly transparent for the end user except that the
from_valuesmethod has been removed. Usually theguid!macro is a more convenient choice anyway, butneworfrom_bytescan also be used if needed.This allows us to delete a bit of code and some tests, as well as slightly reducing our dependency on proc macros as the
uguid::guid!macro is a declarative macro.Checklist