Move Status to uefi-raw, along with related API changes
#768
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is in preparation for moving `Status` to uefi-raw. since the `Error` type and `Result` type alias will not move to uefi-raw, we can't move the `into_with` methods to uefi-raw. And since we can't impl methods on a type defined in another crate, we have to move these methods to a new trait.
Slightly more verbose, but easier to read. Also fits better with a `to_result` function (in the next commit).
This will take the place of into/from for converting from Status to Result. Again, this is needed in preparation for moving `Status` to uefi-raw.
nicholasbishop
force-pushed
the
bishop-move-status-raw
branch
from
c13bf82 to
3cb29d6
Compare
phip1611
approved these changes
Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main purpose of this change is to move
Statustouefi-raw, but doing so requires some changes to the API because onlyStatusis moving touefi-raw, notErrorand theuefi::Resulttype alias. We could move those types too, but I'd rather not because there are a lot of different ways you could translate fromStatustoResult, so doesn't feel right to me to put those inuefi-raw.Since
Statusis in a different package, the conversion methods fromStatustoResulthave to change. Theinto_with*methods are moved to a newStatusExttrait inuefi. I also took this opportunity to rename theminto_with*toto_result_with*; I've always found the old names a bit hard to read. Theimpl From<Status> for Resulthas been changed toStatusExt::to_result, since again we can't impl things cross-package without a separate trait.All of which is to say, a fair amount of mechanical renaming in this PR :) I expect this won't affect end-users of
uefitoo much though, since most of our public APIs returnResultrather thanStatus.Checklist