uefi-macros: Drop !Send and !Sync from unsafe_protocol macro #758
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Protocols can only be used while boot services are active, and that's already a single-threaded environment [1], so these negative traits do not have any effect. (Note that many protocols will still be automatically `!Send`/`!Sync` due to containing raw pointers.) In addition, there's nothing particularly special about protocols; we have lots of structs that are intended for use during boot services and can't be safely shared between threads. There are no threads to worry about in the UEFI environment though, so none of them need to be explictly marked `!Send`/`!Sync`. [1]: https://github.com/rust-lang/rust/blob/4f87a63edcef5c8c06229ff13e0f64f427537378/compiler/rustc_target/src/spec/uefi_msvc_base.rs#L47
phip1611
approved these changes
Apr 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Protocols can only be used while boot services are active, and that's already a single-threaded environment 1, so these negative traits do not have any effect. (Note that many protocols will still be automatically
!Send/!Syncdue to containing raw pointers.)In addition, there's nothing particularly special about protocols; we have lots of structs that are intended for use during boot services and can't be safely shared between threads. There are no threads to worry about in the UEFI environment though, so none of them need to be explictly marked
!Send/!Sync.Checklist