Skip to content

Add uefi to workspace members #713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 26, 2023

Conversation

nicholasbishop
Copy link
Member

I'm confused as to how this hasn't caused problems to be missing -- like why does cargo fmt --all work for the uefi crate even though it was missing from this list?

Checklist

  • Sensible git history (for example, squash "typo" or "fix" commits). See the Rewriting History guide for help.
  • Update the changelog (if necessary)

@phip1611
Copy link
Member

phip1611 commented Mar 26, 2023

All path dependencies residing in the workspace directory automatically become members.

--- https://doc.rust-lang.org/cargo/reference/workspaces.html

That's probably what happened here

@phip1611 phip1611 merged commit eafec33 into rust-osdev:main Mar 26, 2023
@nicholasbishop nicholasbishop deleted the bishop-fix-members branch March 26, 2023 15:13
@nicholasbishop
Copy link
Member Author

nicholasbishop commented Mar 26, 2023

Thanks, makes sense. I was scratching my head over this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants