Replace UnalignedCStr16 with UnalignedSlice
#539
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a generalized version of `UnalignedCStr16`. It's similar to `&[T]`, except it can point to an unaligned slice. This is useful with device path nodes which sometimes end with a DST slice. Since device path nodes are all packed structures, the DST slice may be unaligned. `UnalignedSlice` tries to generally follow the API of a regular slice, with some deviations where necessary (for example it returns copies rather than references, and provides a `copy_to` method instead of `copy_from_slice`).
This should mostly be transparent to callers. An `UnalignedSlice<u16>` slice provides the same `to_cstr16` and `to_cstring16` methods that `UnalignedCStr16` did.
phip1611
approved these changes
Oct 30, 2022
|
LGTM, thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added
UnalignedCStr16a while ago for use with device path nodes, which sometimes end in a DST string. Since device path nodes are all packed structures, the DST slice may be unaligned, so you can't return a normal reference as that would be UB.Some device path nodes end with DST slices that aren't strings. For example,
ACPI _ADRends with a[u32]slice. So we need something more general thanUnalignedCStr16, which is whatUnalignedSliceis. AnUnalignedSlice<u16>provides the sameto_cstr16andto_cstring16methods asUnalignedCStr16, so for existing caller's this should be a pretty transparent change.Checklist