Fixes and improvements for Revision
#529
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phip1611
reviewed
Oct 12, 2022
| @@ -12,6 +12,9 @@ | |||
| `Address` always take a 64-bit value, regardless of target platform. | |||
| - The conversion methods on `DevicePathToText` and `DevicePathFromText` | |||
| now return a `uefi::Result` instead of an `Option`. | |||
| - Changed `SystemTable::firmware_revision` to return a `u32` instead of | |||
phip1611
reviewed
Oct 12, 2022
phip1611
reviewed
Oct 12, 2022
phip1611
reviewed
Oct 12, 2022
|
Very nice! Will approve once you rebased this and all threads are resolved |
nicholasbishop
force-pushed
the
bishop-revision-formatting
branch
from
e9932f1 to
57b45a7
Compare
|
It seems like you have to solve a conflict in the CHANGELOG.md file |
nicholasbishop
force-pushed
the
bishop-revision-formatting
branch
from
57b45a7 to
dc5d019
Compare
Prior to this commit, `SystemTable::firmware_revision` returned a `Revision`. But the `Revision` type is specific to a UEFI spec revision. The format of the vendor revision is vendor specific, so change it to an opaque `u32` since we don't know what its semantics are.
Add a `Display` impl that correctly formats the revision for all spec versions. There are docstring tests that demonstrate it in action. Also removed the `Debug` impl and replaced with a derived impl.
nicholasbishop
force-pushed
the
bishop-revision-formatting
branch
from
dc5d019 to
ad01c57
Compare
|
Rebased to fix conflicts with the clippy lint fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
u32instead of aRevision. TheRevisiontype is specific to a UEFI revision, but the firmware revision doesn't have any defined semantics (it's not necessarily a major.minor format).Revisionto be transparentEFI_2_100for the latest spec revisionDisplayimpl forRevisionthat formats correctly for all spec versions.Debugimpl with a derived impl; the newDisplayimpl can be used for pretty formatting.Checklist
Rewriting History guide for
help.