Fix compilation of the xtask package under Windows and add to CI #438
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The qemu code makes use of some APIs from the `nix` crate, which causes compilation to fail on Windows (native, not WSL). The qemu code can't be easily made to work on Windows, but the rest of xtask should still work fine building, running clippy, etc. Fix by adding `#![cfg(unix)]` to the `qemu` module, as well as the `disk` and `net` modules that are only used by the qemu code. Also changed the `run_vm_tests` action to panic on non-Unix targets.
The new job builds the UEFI packages on a Windows runner instead of Ubuntu. This is a somewhat minimal test (just builds for a single target, doesn't run tests or clippy), but should be enough to ensure that development on Windows (outside of WSL) is in a working state.
GabrielMajeri
force-pushed
the
bishop-fix-xtask-win-comp-2
branch
from
271590f to
a28c037
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #433, the qemu code makes use of some APIs from the
nixcrate, which causes compilation to fail on Windows (native, not WSL). The qemu code can't be easily made to work on Windows, but the rest of xtask should still work fine building, running clippy, etc. Fix by adding#![cfg(unix)]to theqemumodule, as well as thediskandnetmodules that are only used by the qemu code. Also changed therun_vm_testsaction to panic on non-Unix targets.Also add Windows compilation to CI. The new job builds the UEFI packages on a Windows runner instead of Ubuntu. This is a somewhat minimal test (just builds for a single target, doesn't run tests or clippy), but should be enough to ensure that development on Windows outside of WSL is in a working state.