Update set_virtual_address_map() to allow remapping of SystemTable
#301
+41
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… struct. * Updated set_virtual_address_map() to also take a new virtual address for the `SystemTableImpl` used internally. * Provided new `SystemTable` function `get_current_system_table_addr()` to allow the caller to calculate a new virtual address.
foxcob
changed the title
set_virtual_address_map() to allow remapping of SystemTableset_virtual_address_map() to allow remapping of SystemTable, fixes #278
foxcob
changed the title
set_virtual_address_map() to allow remapping of SystemTable, fixes #278set_virtual_address_map() to allow remapping of SystemTable
…o method SystemTable::set_virtual_address_map(). * Cleanup implementation of SystemTable::set_virtual_address_map().
|
Will address the doc error |
src/table/system.rs
Outdated
| /// Changes the runtime addressing mode of EFI firmware from physical to virtual. | ||
| /// It is up to the caller to translate the old SystemTable address to a new virtual | ||
| /// address and provide it for this function. | ||
| /// See ['get_current_system_table_addr'] |
There was a problem hiding this comment.
Here and below in the link, change the single-quotes to backticks (` instead of ') so that code formatting is used.
|
Looks good, thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SystemTablestruct.SystemTableImplused internally.SystemTablefunctionget_current_system_table_addr()to allow the caller to calculate a new virtual address.fixes Remapping UEFI runtime services via set_virtual_address_map() breaks the SystemTable struct #278