uefi-raw: Add EFI_ATA_PASS_THRU_PROTOCOL bindings #1592
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seijikun
force-pushed
the
mr-raw-atapt
branch
3 times, most recently
from
c235aed to
8564b56
Compare
phip1611
approved these changes
Mar 26, 2025
|
@nicholasbishop I think I got all of your suggestions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a (only raw for now) binding to EFI_ATA_PASS_THRU_PROTOCOL [
1d3de7f0-0807-424f-aa69-11a54e19a46f].Also fixed a small spelling mistake in
disk_infothat's related to this.There is a bug in the UEFI spec v2.11 for method:
EFI_ATA_PASS_THRU_PROTOCOL.ResetPort(). Parameterportis falsely portrayed as pointer. I sent in an errata.Should I make the
Reset-method's take a*mut Selfinstead of*const Selfagain?Checklist