Skip to content

Simplify DevicePath to_string return type #1014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 2, 2023
Merged

Simplify DevicePath to_string return type #1014

merged 1 commit into from
Dec 2, 2023

Conversation

nicholasbishop
Copy link
Member

Instead of returning None for out of memory, add a new variant to DevicePathToTextError and return that. That allows the return type to be a plain Result rather than Result<Option>, simplifying usage.

Checklist

  • Sensible git history (for example, squash "typo" or "fix" commits). See the Rewriting History guide for help.
  • Update the changelog (if necessary)

@nicholasbishop
Simplify DevicePath to_string return type
872993f 
Instead of returning `None` for out of memory, add a new variant to
`DevicePathToTextError` and return that. That allows the return type to be a
plain `Result` rather than `Result<Option>`, simplifying usage.
@phip1611 phip1611 added this pull request to the merge queue Dec 2, 2023
Merged via the queue into rust-osdev:main with commit f7b2243 Dec 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phip1611 phip1611 phip1611 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicholasbishop @phip1611