various fixes #157
Merged
various fixes #157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't exactly understand why, but running this in the integration test revealed a different behaviour compared to the unit test. In the unit test environment, it always seemed like the next multiple of 8 is used for each allocation as size. In the integration test, I did not encounter this. I don't know what's the best solution here. Probably, just don't be too strict.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regarding 9cf7630:
I don't exactly understand why, but running this in the integration test
revealed a different behaviour compared to the unit test. In the unit test
environment, it always seemed like the next multiple of 8 is used for each
allocation as size. In the integration test, I did not encounter this. I
don't know what's the best solution here. Probably, just don't be too
strict.