Require len > 1 axis for layout preference #977
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change means that we are not drawn to prefer an axis with length 1 as the "innermost/tightest" axis in Zip.
This fixes the bad performance reported in #932 (comment), specifically select_axis1. The runtime for that benchmark decreases from 21 to 3.4 μs, which is quite substantial and just due to misidentification (in that case) of which axis to prefer for the loop.