Add multi_slice_* methods (supports nested tuples) #716
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jturner314
changed the title
This was referenced Sep 19, 2019
jturner314
force-pushed
the
multislice-methods
branch
2 times, most recently
from
d49ba1b to
3bb5e7d
Compare
jturner314
force-pushed
the
multislice-methods
branch
from
3bb5e7d to
8569279
Compare
jturner314
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements suggestion 4 described in this comment. It provides a
.mutli_slice_mut()method forArrayBaseand a.multi_slice_move()method forArrayViewMut. The slicing information can be passed as (possibly nested) tuples up to length 6. By nesting tuples, it's possible to create arbitrarily many slices.See also the alternative implementation in #717, which I prefer.
The implementation is done, but the tests need some improvement.