Skip to content

Implement Hash to be clippy compliant #654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 11 commits into from
Closed

Implement Hash to be clippy compliant #654

wants to merge 11 commits into from

Conversation

alex179ohm
Copy link

Fix #642

@max-sixty
Copy link
Contributor

@alex179ohm I see you doing lots - I'm a bit concerned that you're doing the same work that I've done in #642. Are you sure this is novel? (Great if it is!)

@alex179ohm
Copy link
Author

Argh.. maybe the master branch is not in sync with the work you've done in the #642?

@max-sixty
Copy link
Contributor

Right, that PR is not yet merged

@LukeMathWalker
Copy link
Member

Given that we merge #642, should I close this? Or does it contain something that was missing there? @alex179ohm

@alex179ohm
Copy link
Author

@LukeMathWalker Close it, we switch to the #657. This issue has been completely merged with the work done by @max-sixty on the #642

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alex179ohm @max-sixty @LukeMathWalker